Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: move core into its own folder #351

Merged
merged 4 commits into from
Aug 23, 2020
Merged

refactor: move core into its own folder #351

merged 4 commits into from
Aug 23, 2020

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 22, 2020 •
edited
Loading

Move core API into its own folder.

core/client.js
core/request.js
core/errors.js
core/symols.js
core/utils.js

@ronag ronag requested a review from mcollina August 22, 2020 14:50
@ronag ronag mentioned this pull request Aug 22, 2020
Closed
17 tasks
@ronag ronag changed the title refactor: move core into own folder refactor: move core into its own folder Aug 22, 2020
@ronag ronag mentioned this pull request Aug 23, 2020
Closed
mcollina
mcollina approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit c17ae44 into master Aug 23, 2020
@ronag ronag deleted the move-core branch April 25, 2021 22:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @mcollina