Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: add jsdoc to lib/web/websocket/constants.js #3564

Merged
merged 2 commits into from
Oct 15, 2024
Merged

chore: add jsdoc to lib/web/websocket/constants.js #3564

merged 2 commits into from
Oct 15, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 7, 2024

we could add // @ts-check at the beginning of the file.

@Uzlopak Uzlopak requested a review from KhafraDev September 7, 2024 11:25
mcollina
mcollina approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit fefadbe into nodejs:main Oct 15, 2024
33 checks passed
@Uzlopak Uzlopak deleted the jsdoc-websocket-constants branch October 15, 2024 16:29
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@mcollina mcollina mcollina approved these changes

@KhafraDev KhafraDev Awaiting requested review from KhafraDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @mcollina @Ethan-Arrowood