-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(types): add missing cache
prop to RequestInit
#3569
Conversation
Lint issues, use 2 spaces instead of 4. I don't think If you want to implement some sort of in-memory caching, see #2760 (comment). |
yeah, will fix
The prop is supported and that's all that matters in this case undici/lib/web/fetch/request.js Lines 974 to 979 in dca0aa0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some type tests for this? We use tsd
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And tomorrow somebody argues, that because the cache field is in the types, we need to implement asap caching.
✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump @mcollina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Also sort the props.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status