Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

rename maxKeepAliveTimeout to keepAliveMaxTimeout #359

Merged
merged 1 commit into from
Aug 24, 2020
Merged

rename maxKeepAliveTimeout to keepAliveMaxTimeout #359

merged 1 commit into from
Aug 24, 2020

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 24, 2020

Keep options grouped by prefix.

    keepAlive,
    keepAliveMaxTimeout,
    keepAliveTimeoutThreshold,

@ronag ronag requested a review from mcollina August 24, 2020 11:47
@ronag ronag force-pushed the keep-alive-timeout-name branch from c040e63 to 15b3bbd Compare August 24, 2020 11:48
delvedor
delvedor approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 2827318 into master Aug 24, 2020
@ronag ronag deleted the keep-alive-timeout-name branch August 24, 2020 12:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronag @mcollina @delvedor