Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: remove unused pre-commit dependency #3599

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

eXhumer
Copy link
Contributor

@eXhumer eXhumer commented Sep 13, 2024

This relates to...

#3593 (comment)

Rationale

pre-commit usage (introduced with commit 25b8a54) has been replaced with husky in #605.

Changes

  • remove pre-commit from devDependencies in package.json

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

* husky is used instead

Signed-off-by: eXhumer <exhumer@exhumer.cc>
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit should in theory run the tests. but it doesnt. dead weight.

@Uzlopak Uzlopak merged commit 0b287b9 into nodejs:main Sep 13, 2024
32 checks passed
@eXhumer eXhumer deleted the remove-unused-precommit-dependency branch September 13, 2024 13:36
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants