Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fetch: make fullyReadBody sync #3603

Merged
merged 2 commits into from
Sep 15, 2024
Merged

fetch: make fullyReadBody sync #3603

merged 2 commits into from
Sep 15, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 13, 2024 •
edited
Loading

closer to the spec and avoiding an async call.

@Uzlopak Uzlopak requested a review from KhafraDev September 13, 2024 19:49
mcollina
mcollina approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 56f9156 into main Sep 15, 2024
38 checks passed
@Uzlopak Uzlopak deleted the sync-fullyReadBody branch September 15, 2024 20:29
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@metcoder95 metcoder95 metcoder95 approved these changes

@mcollina mcollina mcollina approved these changes

@KhafraDev KhafraDev Awaiting requested review from KhafraDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Uzlopak @mcollina @metcoder95 @KhafraDev