feat: support request cache control directives #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
from
3ebfdd8 to
9a15ece
Compare
mcollina
reviewed
Oct 15, 2024
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
from
9a15ece to
a0b52e3
Compare
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
from
a0b52e3 to
d034c54
Compare
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
2 times, most recently
from
13fe5e0 to
4c3dd04
Compare
|
cc @ronag PTAL |
ronag
approved these changes
Nov 18, 2024
metcoder95
reviewed
Nov 18, 2024
ronag
reviewed
Nov 18, 2024
Co-authored-by: Robert Nagy <ronagy@icloud.com> Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
from
6ca427c to
799d7ea
Compare
|
@metcoder95 PTAL |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a draft since #3562 isn't landed. Until it is landed, this will be based off of that pr's branch. For the actual diff see flakey5/undici@flakey5/3231...flakey5:undici:flakey5/20240924/cli-cache-controlThis relates to...
Adding client side http caching (#3562)
Rationale
Changes
Features
RFC9111 allows the request to specify a cache-control header with directives that can affect how we handle the request in the cache interceptor (re 5.2.1). This adds support for them.
Bug Fixes
Breaking Changes and Deprecations
Status
cc @mcollina @ronag