fix: dns interceptor ip ttl #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes so that the record lives at most ttl time since lookup by not refreshing the timeout when picked.
luddd3
changed the title
metcoder95
reviewed
Oct 25, 2024
lib/interceptor/dns.js
Outdated
| const records = { records: { 4: null, 6: null } } | ||
| for (const record of addresses) { | ||
| record.timestamp = timestamp | ||
| record.ttl = opts.maxTTL |
There was a problem hiding this comment.
If the record already contains a ttl let's preserve it, otherwise default to maxTTL.
On top, let's use the min from both values.
There was a problem hiding this comment.
I have added it.
How do you feel about expecting the record result to be in ms? dns.lookup doesn't usually provide ttl. dns.resolve does, but it's ttl, and other time properties, are in seconds.
https://nodejs.org/api/dns.html#dnsresolveanyhostname-callback
Take the minimum value between the record TTL and the maxTTL from options. The record TTL value is expected to be in ms even though the `dns.resolve` methods provide it in seconds. The reasons are that: * it avoids extra manipulation in the `setRecords` method * `dns.lookup` does not provide ttl * custom provided lookup method's using `dns.resolve` must be manipulated anyway by adding a value for the family.
mcollina
reviewed
Oct 25, 2024
metcoder95
approved these changes
Oct 27, 2024
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
How long time to cache the dns records from the dns interceptor.
Rationale
For how long time the dns records from the dns interceptor should live.
Changes
Set timestamp once on each resolved record and compare the ttl to that timestamp. If the record is too old, remove it.
Features
Bug Fixes
N/A
Breaking Changes and Deprecations
Status