Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Skip debuglog tests #3810

Merged
merged 2 commits into from
Nov 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/node-test/debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ const { tspl } = require('@matteo.collina/tspl')
// eslint-disable-next-line no-control-regex
const removeEscapeColorsRE = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g

const isNode23Plus = process.versions.node.split('.')[0] >= 23
const isCITGM = !!process.env.CITGM

test('debug#websocket', { skip: !process.versions.icu || isCITGM }, async t => {
test('debug#websocket', { skip: !process.versions.icu || isCITGM || isNode23Plus }, async t => {
const assert = tspl(t, { plan: 6 })
const child = spawn(
process.execPath,
Expand Down Expand Up @@ -39,6 +40,7 @@ test('debug#websocket', { skip: !process.versions.icu || isCITGM }, async t => {
})
child.stderr.on('end', () => {
const lines = extractLines(chunks)
console.log(lines)
Uzlopak marked this conversation as resolved.
Show resolved Hide resolved
assert.strictEqual(lines.length, assertions.length)
for (let i = 1; i < lines.length; i++) {
assert.match(lines[i], assertions[i])
Expand All @@ -48,7 +50,7 @@ test('debug#websocket', { skip: !process.versions.icu || isCITGM }, async t => {
await assert.completed
})

test('debug#fetch', { skip: isCITGM }, async t => {
test('debug#fetch', { skip: isCITGM || isNode23Plus }, async t => {
const assert = tspl(t, { plan: 7 })
const child = spawn(
process.execPath,
Expand Down Expand Up @@ -85,7 +87,7 @@ test('debug#fetch', { skip: isCITGM }, async t => {
await assert.completed
})

test('debug#undici', { skip: isCITGM }, async t => {
test('debug#undici', { skip: isCITGM || isNode23Plus }, async t => {
// Due to Node.js webpage redirect
const assert = tspl(t, { plan: 7 })
const child = spawn(
Expand Down
Loading