Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(#3817): send servername for SNI on TLS (#3821) [backport] #3864

Merged
merged 4 commits into from
Nov 22, 2024
Merged

fix(#3817): send servername for SNI on TLS (#3821) [backport] #3864

merged 4 commits into from
Nov 22, 2024
+2,163 −1

Conversation

metcoder95
Copy link
Member

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@metcoder95
fix(#3817): send servername for SNI on TLS (#3821)
1f6f91e 
* fix(#3817): send servername for SNI on TLS

* fix: set host header to servername

* refactor: attach regardless

(cherry picked from commit b93a834)
metcoder95
metcoder95 commented Nov 21, 2024
View reviewed changes
lib/interceptor/dns.js
@@ -0,0 +1,375 @@
'use strict'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know we didn't backport dns interceptor

@metcoder95 metcoder95 requested review from mcollina and ronag November 22, 2024 09:28
mcollina
mcollina approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a0220f1 into v6.x Nov 22, 2024
34 checks passed
@Uzlopak Uzlopak deleted the backport-3821-to-v6.x branch December 31, 2024 18:19
@myfreeer myfreeer mentioned this pull request Jan 22, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag Awaiting requested review from ronag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metcoder95 @mcollina