feat: new hooks #3878
Merged
feat: new hooks #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
new-hooks2
branch
10 times, most recently
from
9ab150a to
f37d5f4
Compare
ronag
force-pushed
the
new-hooks2
branch
3 times, most recently
from
41c3b90 to
c22b5c2
Compare
ronag
force-pushed
the
new-hooks2
branch
2 times, most recently
from
f0cf2a8 to
9d2bf4f
Compare
Closed
ronag
requested review from
mcollina,
metcoder95 and
ShogunPanda
and removed request for
mcollina
|
I'm unsure about A. Is it necessary? |
|
This looks good to me. Can you update the docs? |
mcollina
approved these changes
Nov 25, 2024
| onData: () => {}, | ||
| onComplete: 'INVALID' | ||
| }), new InvalidArgumentError('invalid onComplete method')) | ||
| }) |
There was a problem hiding this comment.
The redirect interceptor has some kind of assertion of the handler that does not exist anywhere else and is difficult to have compat with through the wrap/unwrap.
ronag
force-pushed
the
new-hooks2
branch
2 times, most recently
from
ec77100 to
78dc2e6
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.