Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ignore not exists queue request on client error #3890

Closed
wants to merge 1 commit into from

Conversation

fengmk2
Copy link
Contributor

@fengmk2 fengmk2 commented Nov 27, 2024

This relates to...

closes #3857

Rationale

Changes

Features

Bug Fixes

Ignore not exists request on queue

Breaking Changes and Deprecations

Status

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this just hides an underlying issue...

@fengmk2
Copy link
Contributor Author

fengmk2 commented Nov 28, 2024

Thanks for opening a PR! Can you please add a unit test?

No problem, I'll try to find out the conditions for reproduction and add unit tests

@fengmk2 fengmk2 marked this pull request as draft November 28, 2024 01:06
@metcoder95
Copy link
Member

Agree with @ronag.
I believe this was already fixed with #3875

@fengmk2 fengmk2 closed this Nov 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'onError')
4 participants