Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: add advanced usage examples for ProxyAgent #3906

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

mertcanaltin
Copy link
Member

I have added additional examples to the ProxyAgent documentation, including how to use ProxyAgent with fetching, custom proxy server setup and HTTPS tunneling.

I would be grateful if you have any suggestions 🚀

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, you should add one example that configures it as a global dispatcher, so that it can be used without passing it.

@mertcanaltin
Copy link
Member Author

mertcanaltin commented Nov 30, 2024

Good work, you should add one example that configures it as a global dispatcher, so that it can be used without passing it.

I added, thanks a lot for the suggestion

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metcoder95 metcoder95 merged commit c417633 into nodejs:main Dec 3, 2024
29 of 31 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants