fix mimetype parser wrong operator

[tsctx]

The current code does not include past the end of input, so add equal sign.

[mcollina]

Can you include a test? Or maybe there is a failing WPT this is fixing?

[KhafraDev]

Tests passing on main: 1031
Tests passing here: 1031

[tsctx]

This step is there to skip the rest if it is not needed, so all tests pass without this change.

position is never greater than the length of input, so it is a dead code.

For some reason, this is the only place where the greater-than was used, while other places used the correct greater-than or equal.

[tsctx]

https://github.com/search?q=repo%3Anodejs%2Fundici+path%3A%2F%5Elib%5C%2Fweb%2F+%2FIf+position+is+past+the+end+of+input%2F&type=code

[KhafraDev]

I'm not arguing with your logic (and I agree with it), but if no test failures change I would assume this code is still dead code. I would like to see a test for both of these conditions, though.

[tsctx]

I'm not arguing with your logic (and I agree with it), but if no test failures change I would assume this code is still dead code. Should these be replaced with assertions instead?

As I mentioned before, this part of the process is to skip an extra step (at this point, an invalid entry or exit), so it is virtually untestable since it does not make any difference whether this part is there or not.

[KhafraDev]

Both conditions can be caught with tests?

1. Find an input where parseMIMEType returns failure on that condition.
2. Find an input with an invalid parameter that triggers the if and make sure it isn't set on the returned object's parameters.

[tsctx]

Both conditions can be caught with tests?

1. Find an input where parseMIMEType returns failure on that condition.

undici/test/fixtures/wpt/mimesniff/mime-types/resources/mime-types.json

Line 407 in 9e6d34d

"input": "bogus",

2. Find an input with an invalid parameter that triggers the if and make sure it isn't set on the returned object's parameters.

undici/test/fixtures/wpt/mimesniff/mime-types/resources/mime-types.json

Line 321 in 9e6d34d

"input": "x/x;test",

I have checked wpt mimesniff tests, these cases are covered.

[KhafraDev]

It would be nice to get codecov working again, so we could really see what is and isn't being tested without doing it manually.