Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: cleanup cache tests #3926

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Dec 5, 2024

The tests currently cover a good amount but are a bit messy. This cleans them up and adds some more checks around some required behaviors

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5
Copy link
Member Author

flakey5 commented Dec 5, 2024

cc @mcollina @ronag

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c5dfb3d into nodejs:main Dec 5, 2024
31 checks passed
This was referenced Dec 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants