More cache fixes #3955
Merged
More cache fixes #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
ronag
approved these changes
Dec 17, 2024
mcollina
reviewed
Dec 17, 2024
metcoder95
reviewed
Dec 17, 2024
Comment on lines
+202
to
+203
| // TODO (fix): Should we resume even if was paused downstream? | ||
| controller.resume() |
There was a problem hiding this comment.
Let's aim to keep it in sync with the controller as possible; at the end it is what allow to apply back pressure while consuming the body
| this.#writeStream | ||
| .on('drain', () => controller.resume()) | ||
| .on('error', function () { | ||
| // TODO (fix): Make error somehow observable? |
There was a problem hiding this comment.
If we cannot store the response's body, best will be to just handover the body to the caller and fail silently; I'm thinking on some sort of on error event here?
There was a problem hiding this comment.
I'm thinking on some sort of on error event here?
Where would this be?
There was a problem hiding this comment.
Good question; maybe the cache-handler itself? I believe we do not have reference to the dispatcher at this point but the dispatch method.
There was a problem hiding this comment.
Let's explore it in further PR
Co-authored-by: Carlos Fuentes <me@metcoder.dev>
metcoder95
approved these changes
Dec 18, 2024
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Date('Wed, aa Dec 2024 23:20:57 GMT'), the day defaults to 1 instead of it being marked as an invalid date)last-modifiedWith this, we're passing 65% of the tests in the suite. The two main behaviors that are left are invalidating the urls given in the
Locationheader and some behaviors regarding status codes other than 200 and 307 (note these are still optional)cc @mcollina