Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

types(websocket): Import from stream/web #4038

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jiralite
Copy link

@Jiralite Jiralite commented Feb 1, 2025

This relates to...

N/A

Rationale

ReadableStream and WritableStream were not imported in the typings. This pull request imports them from stream/web.

Changes

Features

N/A

Bug Fixes

Fixes TypeScript compilation error:

types/websocket.d.ts(167,15): error TS2304: Cannot find name 'ReadableStream'.
types/websocket.d.ts(168,15): error TS2304: Cannot find name 'WritableStream'.

https://github.com/discordjs/discord.js/actions/runs/13081715315/job/36506493876

Breaking Changes and Deprecations

N/A

Status

Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some test to it?

@Jiralite Jiralite force-pushed the types/websocket-import branch from c2f61cb to 003e3e5 Compare February 2, 2025 10:14
@Jiralite Jiralite changed the title types(websocket): import from stream/web types(websocket): Import from stream/web Feb 2, 2025
@Jiralite Jiralite requested a review from metcoder95 February 2, 2025 10:14
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jiralite Jiralite force-pushed the types/websocket-import branch from 003e3e5 to ecd828e Compare February 7, 2025 21:41
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants