Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Exceptions not being thrown in test harness #370

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

zprobst
Copy link
Member

@zprobst zprobst commented Nov 19, 2024

No description provided.

@zprobst zprobst requested a review from ccloes as a code owner November 19, 2024 13:58
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.93%. Comparing base (876d98a) to head (9bb0026).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nodestream/pipeline/progress_reporter.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   97.95%   97.93%   -0.02%     
==========================================
  Files         147      147              
  Lines        5318     5320       +2     
==========================================
+ Hits         5209     5210       +1     
- Misses        109      110       +1     
Flag Coverage Δ
3.10-macos-latest 97.91% <50.00%> (?)
3.10-ubuntu-latest 97.89% <50.00%> (-0.02%) ⬇️
3.10-windows-latest 97.85% <50.00%> (-0.02%) ⬇️
3.11-macos-latest 97.89% <50.00%> (-0.04%) ⬇️
3.11-ubuntu-latest 97.89% <50.00%> (-0.02%) ⬇️
3.11-windows-latest 97.85% <50.00%> (?)
3.12-macos-latest 97.91% <50.00%> (-0.02%) ⬇️
3.12-ubuntu-latest 97.89% <50.00%> (-0.02%) ⬇️
3.12-windows-latest 97.87% <50.00%> (?)
3.13-macos-latest 97.89% <50.00%> (?)
3.13-ubuntu-latest 97.89% <50.00%> (?)
3.13-windows-latest 97.85% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zprobst zprobst merged commit 493d940 into main Nov 20, 2024
14 of 16 checks passed
@zprobst zprobst deleted the fix/testing-exception-handle branch November 20, 2024 14:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants