Unmarshalling dynamo data officially. #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 97.93% 97.91% -0.02%
==========================================
Files 147 147
Lines 5325 5286 -39
==========================================
- Hits 5215 5176 -39
Misses 110 110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
angelosantos4
commented
Jan 7, 2025
| ({"BOOL": "False"}, False), | ||
| ({"SS": ["StringA", "StringB"]}, ["StringA", "StringB"]), | ||
| ({"NS": ["100", "200", "1.0"]}, [100, 200, 1.0]), | ||
| ({"BS": ["abcdef", "xyz123"]}, [b"abcdef", b"xyz123"]), |
There was a problem hiding this comment.
Notably in these tests, the decoder recognizes *S as actual sets rather than lists. For the most part this will be fine given that dynamo likely implements these as sets internally.
There was a problem hiding this comment.
Also the Booleans effectively return as python booleans rather than strings.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using boto3 deserializer method to unmarshall the dynamo records rather than our own version. In order to use the best standards for type standardization.