You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I set up this jsfiddle http://jsfiddle.net/perludum/915y4683/ with a broken link in it (and testing the nice new spinner feature :).The third image has set a broken link. When you click on it directly, it keeps showing the spinner. A different behavior is called when you click through the gallery up to the third image.
In this case, it would be nice to replace the image with a short message like 'image not found' or something when the source turns out to be broken. The message could be shown in the lightbox (without the .featherlight-loading class).
The text was updated successfully, but these errors were encountered:
Thank you for the fiddle, it's greatly appreciated.
Indeed, error handling for images was broken. I've improved it slightly so the callbacks and all are actually set. I'll have to think of a better handling mechanism for the future, maybe some kind of hook?
I set up this jsfiddle http://jsfiddle.net/perludum/915y4683/ with a broken link in it (and testing the nice new spinner feature :).The third image has set a broken link. When you click on it directly, it keeps showing the spinner. A different behavior is called when you click through the gallery up to the third image.
In this case, it would be nice to replace the image with a short message like 'image not found' or something when the source turns out to be broken. The message could be shown in the lightbox (without the .featherlight-loading class).
The text was updated successfully, but these errors were encountered: