Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

behavior on broken image links #116

Open
perludum opened this issue Feb 20, 2015 · 1 comment
Open

behavior on broken image links #116

perludum opened this issue Feb 20, 2015 · 1 comment

Comments

@perludum
Copy link

I set up this jsfiddle http://jsfiddle.net/perludum/915y4683/ with a broken link in it (and testing the nice new spinner feature :).The third image has set a broken link. When you click on it directly, it keeps showing the spinner. A different behavior is called when you click through the gallery up to the third image.

In this case, it would be nice to replace the image with a short message like 'image not found' or something when the source turns out to be broken. The message could be shown in the lightbox (without the .featherlight-loading class).

@marcandre
Copy link
Collaborator

Thank you for the fiddle, it's greatly appreciated.

Indeed, error handling for images was broken. I've improved it slightly so the callbacks and all are actually set. I'll have to think of a better handling mechanism for the future, maybe some kind of hook?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants