You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What kind of issue is this? (put 'x' between the square brackets)
Question. This issue tracker is not the place for questions. If you want to ask how to do
something, or to understand why something isn't working the way you expect it to, use http://stackoverflow.com/questions/ask .
Provide working code, starting from http://jsfiddle.net/JNsu6/15/.
We monitor the tag featherlight.js.
Bug report. If you’ve found a bug, you must provide a minimal example in a CodePen,
starting from http://jsfiddle.net/JNsu6/15/ .
I noticed that images are not shown in full size when the lightbox is open even though the window would be large enough. This is especially visible for images showing text. Here is a fiddle showing the problem: http://jsfiddle.net/rwwtv2az/2/ (you have to remove the javascript part to see the problem).
The problem is caused by the -1 in the ratio calculation of the resize function
/* Note: -1 to avoid rounding errors */varratio=Math.max(w/(this.$content.parent().width()-1),h/(this.$content.parent().height()-1));
It states that this is due to rounding errors but it causes the ratio to be slightly above 1 and hence makes the image slightly smaller.
In the fiddle I fixed this issue by applying the procedure only if the image is smaller than the parent. If you think this is a proper way of fixing the problem, I could make a PR.
The text was updated successfully, but these errors were encountered:
deefha
added a commit
to deefha/klan2016-viewer
that referenced
this issue
Aug 3, 2018
What kind of issue is this? (put 'x' between the square brackets)
Question. This issue tracker is not the place for questions. If you want to ask how to do
something, or to understand why something isn't working the way you expect it to, use
http://stackoverflow.com/questions/ask .
Provide working code, starting from http://jsfiddle.net/JNsu6/15/.
We monitor the tag
featherlight.js
.Bug report. If you’ve found a bug, you must provide a minimal example in a CodePen,
starting from http://jsfiddle.net/JNsu6/15/ .
Feature Request. Make sure there's no good way to do what you want first;
consider asking on http://stackoverflow.com/questions/ask first.
I noticed that images are not shown in full size when the lightbox is open even though the window would be large enough. This is especially visible for images showing text. Here is a fiddle showing the problem: http://jsfiddle.net/rwwtv2az/2/ (you have to remove the javascript part to see the problem).
The problem is caused by the
-1
in the ratio calculation of theresize
functionIt states that this is due to rounding errors but it causes the ratio to be slightly above 1 and hence makes the image slightly smaller.
In the fiddle I fixed this issue by applying the procedure only if the image is smaller than the parent. If you think this is a proper way of fixing the problem, I could make a PR.
The text was updated successfully, but these errors were encountered: