Swipe

[marcandre]

The behavior of the gallery on mobile is pretty bad. It first requires a tap on the previous/next button, which we must "guess" exist, and the a tap on the button.

Consider getting rid of the navigation buttons altogether and detecting swipes instead.

Here's an example using my tiny lib. Consider bundling it?

[marcandre]

@noelboss So what should we do exactly here? Fix the mobile non-swipe version? Merge this commit and put in Readme/wiki that one should load the swipe lib if desired? Both?

[noelboss]

I like the idea of it, but I would like to think about it a little more. F.e. Is there an easy way to make this more flexible? (Also, I m thinking about moving gallery to the wiki as an implementation example.)

[marcandre]

Right, if we could have a way to use different 'swipe' libs.

I'd say the gallery is too "big" to be in a wiki. A wiki isn't accessible under git, doesn't have releases, no issues can be filed, etc...

I also don't see it as a example but as a directly usable library.

I'd keep it here or split into it's own repo.

[marcandre]

I made a survey of existing libraries. All use the same jquery events 'swipeleft' and 'swiperight', so it's easy to support them all. I've made a wiki entry and will modify the commit to use improved detection for any of these.

swipeleft and swiperight could be user configurable, but I'd say let's keep things simple and we can amend that if there's an actual need.

[marcandre]

Ok, I've updated my own swipe library and I've updated the wiki. Support is either for jQuery swipe aware libraries (any of the 3/4 I found) or non-jQuery libs (I found Hammer).

[noelboss]

Great. I think I used Hammer before. The thought I have in mind with the wiki is more of a loose range of possible implementations – since there are mostly very specific, I have the impression this could fit the need very well and releases are not needed since they are not real plugins. You know what I mean? Create a simple plugin (featherlight) thats easy to understand and adapt and add a lot of implementation examples.
BTW, the github wiki is also a git repo with commits etc ;)

[marcandre]

Merged in as a2e4e19

[noelboss]

Thank you!

[noelboss]

This breaks when I test it.
I think, $.events is not jQuery 1.7 compatible which is (as of now) the lowest version supported... You should always check your code using the index.html and gallery.html pages.

[marcandre]

Ok, I'll fix this.

Any reason why index.html refers to release/ and not src/?

[marcandre]

Fixed, and added mention in wiki

[marcandre]

Mmm, still breaking. I really need to install automated tests...

[marcandre]

Ok, should finally be ok.