Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat!: ACIR bytecode encoding with Base64 #1935

Merged
merged 9 commits into from
Jul 17, 2023
Merged

feat!: ACIR bytecode encoding with Base64 #1935

merged 9 commits into from
Jul 17, 2023

Conversation

kobyhallx
Copy link
Contributor

Description

Problem*

Towards noir-lang/acvm#434

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kobyhallx kobyhallx changed the title Kh b64 bytecode feat!: ACIR bytecode encoding with Base64 Jul 14, 2023
@kobyhallx kobyhallx marked this pull request as draft July 14, 2023 19:55
@kobyhallx
Copy link
Contributor Author

Draft, until noir-lang/acvm#436 merges in

@charlielye charlielye marked this pull request as ready for review July 15, 2023 13:36
@charlielye charlielye self-requested a review July 15, 2023 13:36
charlielye
charlielye previously approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@charlielye charlielye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kobyhallx kobyhallx enabled auto-merge July 15, 2023 14:22
TomAFrench
TomAFrench reviewed Jul 17, 2023
View reviewed changes
@kobyhallx kobyhallx added this pull request to the merge queue Jul 17, 2023
Merged via the queue into master with commit 347cfc4 Jul 17, 2023
@kobyhallx kobyhallx deleted the kh-b64-bytecode branch July 17, 2023 13:50
@kevaundray kevaundray mentioned this pull request Jul 17, 2023
Merged
This was referenced Jul 18, 2023
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@charlielye charlielye charlielye approved these changes

@TomAFrench TomAFrench Awaiting requested review from TomAFrench

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobyhallx @charlielye @TomAFrench