Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Decode 63 (Base64) to 47 (ASCII) #3

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ewynx
Copy link
Contributor

@ewynx ewynx commented Aug 22, 2024

Description

Decode value 63 in Base64 to 47 in ASCII (instead of 62 as was the case).

Problem*

Resolves #2

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@@ -41,7 +41,7 @@ impl Base64DecodeBE {
97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122,// 26-51 (a-z)
48, 49, 50, 51, 52, 53, 54, 55, 56, 57,// 52-61
43,// 62
62// 63
47// 63
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@jzaki jzaki merged commit 55897cd into noir-lang:main Sep 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect decoding of Base64 value "63"
2 participants