Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Edit toot #2179

Open
nolanlawson opened this issue Nov 12, 2022 · 9 comments
Open

Edit toot #2179

nolanlawson opened this issue Nov 12, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@nolanlawson
Copy link
Owner

I guess this is a new thing in Mastodon? Needs some way to determine whether or not the server supports it, though. E.g. I dunno if Pleroma supports this.

@nolanlawson nolanlawson added the enhancement New feature or request label Nov 12, 2022
@tbroyer
Copy link
Contributor

tbroyer commented Nov 25, 2022

Will apparently be in Pleroma 2.5.0: https://git.pleroma.social/pleroma/pleroma/-/merge_requests/3678

I suppose that one way to detect support is to look at the version field of /api/v1/instance, and look for a version >= 3.5.0 (or 4.0.0 for when the feature was enabled in Mastdon's web UI). Pleroma returns 2.7.2 currently so it wouldn't be detected as supporting editing. No idea what it'll return when they release 2.5.0 with editing feature so might have to revisit (will they still return 2.7.2 (compatible; Pleroma 2.5.0)? In which case detection would have to look for the Pleroma version as well)

@nolanlawson
Copy link
Owner Author

@tbroyer Thanks for the info. Usually what I do in these sorts of situations is look to other fediverse clients and see how they handle it. E.g. max_toot_chars used to be the way to communicate the number of max toot characters, but that changed: #2187

From a glance at https://mastodon.social/api/v1/instance though I don't see anything related to toot editing, so probably version-sniffing will be the only solution.

@tbroyer
Copy link
Contributor

tbroyer commented Nov 25, 2022

The official Android application apparently doesn't do any detection/sniffing, whereas the iOS application doesn't support editing yet.

Tooot apparently uses version sniffing for everything: https://github.com/tooot-app/app/blob/bd750da9d5888cde07fb8f29ded9821695e1de07/src/helpers/features.json / https://github.com/tooot-app/app/blob/bd750da9d5888cde07fb8f29ded9821695e1de07/src/utils/slices/instancesSlice.ts#L326-L335

Same for iMast: https://github.com/cinderella-project/iMast/blob/931b265013aa0b11a683dba67f435bf3dd6bf4cd/Sources/iOS/App/CustomViews/Post/PostDetail/MastodonPostDetailReactionBarViewController.swift#L138-L142

Tusky will likely do version-sniffing: tuskyapp/Tusky#2828 (comment)

Other apps I've looked at don't support editing yet.

@jdaviescoates
Copy link

Yeah, I just came here to say that I miss having the new edit function when using Pinafore

(and Tusky doesn't seem to have it yet either so missing it there too!)

@tbroyer
Copy link
Contributor

tbroyer commented Dec 6, 2022

Fwiw, there are several tasks:

  1. support toots edited in other applications (generally toots by other users)
  2. support editing own toots (https://docs.joinmastodon.org/methods/statuses/#edit)

@NickColley
Copy link
Collaborator

I wonder if we replace the 'Delete and redraft' option with edit for clients on a mastodon version that support it, can anyone think of a reason to keep both options?

@expertmanofficial

This comment was marked as abuse.

@expertmanofficial

This comment was marked as abuse.

@mirabilos
Copy link

Nah, keep Delete and redraft as well, but please do enable editing. GotoSocial has caught up and supports it as well now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants