Add post editing capability #2828
Conversation
|
Found two TODOs just now:
|
|
Not a dev so apologies in advance if I state obvious things or ask stupid questions. Not sure if I am supposed to answer here as a user.
Checking the Mastodon version per account (maybe at login) would give you that information and might be useful for future features too. Probably outside of the scope of this feature.
The edited post should stay at the original place/time in the timeline. But there needs to be a way to open the revisions. In the web client there is an arrow or something next to the date/time when you open an edited post. There you can open the revisions.
Polls can be edited as a whole and restarted, but it is not possible to edit the options of a running poll. |
|
I think assuming the server supports it is fine. Most Mastodon instances are on 4.0.
Wait, with delete & redraft we don't reupload but reuse the media id, this should work here as well 🤔 |
There is an api where one can get the post source: |
|
Ok, mentions actually do work - the problem I saw earlier was either workflow-related, or maybe because I was testing while all instances were heavily loaded with new users |
| @@ -138,6 +138,7 @@ class SendStatusService : Service(), Injectable { | |||
| statusToSend.mediaProcessed.forEachIndexed { index, processed -> | |||
| if (!processed) { | |||
| when (mastodonApi.getMedia(statusToSend.mediaIds[index]).code()) { | |||
| 404, // This can happen when editing posts with media that were uploaded a long time ago | |||
There was a problem hiding this comment.
@connyduck Does this make any sense to you?
There was a problem hiding this comment.
No, because that codepath should only be hit when reuploading 🤔
|
Ok, I think this is ready for other people to try it.
|
| @@ -137,7 +137,7 @@ data class Status( | |||
| ) | |||
| } | |||
|
|
|||
| private fun getEditableText(): String { | |||
| fun getEditableText(): String { | |||
There was a problem hiding this comment.
No, don't use this. This is only here to have a fallback for ancient Mastodon versions before deleting returned the status source. To get the status source without deleting a status, call GET /api/v1/statuses/:id/source.
Fixes editing posts with existing media
| abstract class SFragment : Fragment(), Injectable { | ||
| protected abstract fun removeItem(position: Int) | ||
| protected abstract fun onReblog(reblog: Boolean, position: Int) | ||
| private var bottomSheetActivity: BottomSheetActivity? = null |
There was a problem hiding this comment.
| private var bottomSheetActivity: BottomSheetActivity? = null | |
| private lateinit var bottomSheetActivity: BottomSheetActivity |
then you don't need any calls with ?
There was a problem hiding this comment.
Oops, thought I had caught all of these
| if (activeAccount != null) { | ||
| loggedInUsername = activeAccount.username | ||
| } | ||
| val mentionedUsernames: MutableSet<String?> = LinkedHashSet( |
There was a problem hiding this comment.
MutableSet<String>, then you don't need the map { it!! } below
| menu.add(0, R.id.pin, 1, getString(if (status.isPinned()) R.string.unpin_action else R.string.pin_action)) | ||
| } | ||
| Status.Visibility.PRIVATE -> { | ||
| var reblogged = status.reblog?.reblogged ?: status.reblogged |
There was a problem hiding this comment.
| var reblogged = status.reblog?.reblogged ?: status.reblogged | |
| val reblogged = status.reblog?.reblogged ?: status.reblogged |
| menu.findItem(R.id.status_unreblog_private).isVisible = reblogged | ||
| } | ||
| else -> { | ||
| // TODO: anything? |
| AlertDialog.Builder(requireActivity()) | ||
| .setMessage(R.string.dialog_redraft_post_warning) | ||
| .setPositiveButton(android.R.string.ok) { _: DialogInterface?, _: Int -> | ||
| timelineCases!!.delete(id) |
There was a problem hiding this comment.
| timelineCases!!.delete(id) | |
| timelineCases.delete(id) |
| .show() | ||
| } | ||
|
|
||
| private fun editStatus(id: String, position: Int, status: Status) { |
| startActivity(newHashtagIntent(requireContext(), tag)) | ||
| } | ||
|
|
||
| protected fun openReportPage(accountId: String, accountUsername: String, statusId: String) { |
There was a problem hiding this comment.
can be private (showConfirmDeleteDialog as well)
This doesn't seem to require a ton of additional work from delete/redraft.
Verified use cases:
We still don't have a solution for support detection (
status.edited_atwill be null both when the instance doesn't provide it and when the instance sends it as null (thanks, json!))I'm also not sure what to do with the edited date: set it as the date for the post in the timeline? ignore it? something else?(covered by #2935)Finally, I haven't thoroughly tested all the edge cases yet. I feel like the fact that we're leveraging the existing draft system etc. means that it should be pretty solid, but there are still a lot of different variables wrt attachments, polls, scheduling, etc., that need to be actually explored.
#2759