Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #869: Allow logged out user to view content on default instance #872

Closed
wants to merge 2 commits into from

Conversation

uiri
Copy link
Contributor

@uiri uiri commented Jan 10, 2019

This is at the works-on-my-server stage. It still needs tests.

Open questions:

  • Is a variable buried deep inside the source the right place for configuring the default instance?
  • Should support for no default instance be maintained? If not, what should the default default instance be?

For now, I've left the default default instance as mastodon.social even though obviously I use a different value for my testing.

@nolanlawson
Copy link
Owner

This is an interesting PR, thanks! I'm not sure I'd like to merge it, though, since I kind of disagree that Pinafore should privilege any one instance over another one (e.g. mastodon.social). I think it should be a neutral third-party app (unless maybe when self-hosted by another instance, TBD).

If you want to override currentInstance then unfortunately it's going to be a bit hard because it's referenced everywhere. The best solution may be to turn it into a computed property (e.g. here and then make sure that currentInstance is never set() but rather computed from some other property. Otherwise you will probably miss a spot.

@uiri uiri force-pushed the logged-out-access branch from 0eaa557 to cb57ae0 Compare January 12, 2019 19:59
@uiri uiri closed this Jan 12, 2019
@uiri uiri deleted the logged-out-access branch January 12, 2019 20:33
@uiri uiri restored the logged-out-access branch January 12, 2019 20:33
@uiri uiri reopened this Jan 12, 2019
@nolanlawson
Copy link
Owner

Closing for now, as I'm not sure about having a default instance for all of Pinafore. Maybe in order to solve #35, we could instead have a global environment variable that could be used during building, and which would auto-log in to the given instance by default using a cookie.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants