Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ChatView: make context menus more intuitive #2324

Merged
merged 2 commits into from
May 9, 2024
Merged

ChatView: make context menus more intuitive #2324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b01ee4d
ChatView: fix deprecation warning
cebtenzzre May 8, 2024
0aa6ab0
ChatView: make context menus more intuitive
cebtenzzre May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions gpt4all-chat/qml/ChatView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,7 @@ Rectangle {
anchors.fill: parent
acceptedButtons: Qt.RightButton

onClicked: {
onClicked: (mouse) => {
if (mouse.button === Qt.RightButton) {
conversationContextMenu.x = conversationMouseArea.mouseX
conversationContextMenu.y = conversationMouseArea.mouseY
Expand All @@ -1082,11 +1082,19 @@ Rectangle {
id: conversationContextMenu
MenuItem {
text: qsTr("Copy")
enabled: myTextArea.selectedText !== ""
height: enabled ? implicitHeight : 0
onTriggered: myTextArea.copy()
}
MenuItem {
text: qsTr("Select All")
onTriggered: myTextArea.selectAll()
text: qsTr("Copy Message")
enabled: myTextArea.selectedText === ""
height: enabled ? implicitHeight : 0
onTriggered: {
myTextArea.selectAll()
myTextArea.copy()
myTextArea.deselect()
}
}
}

Expand Down Expand Up @@ -1441,7 +1449,7 @@ Rectangle {
anchors.fill: parent
acceptedButtons: Qt.RightButton

onClicked: {
onClicked: (mouse) => {
if (mouse.button === Qt.RightButton) {
textInputContextMenu.x = textInputMouseArea.mouseX
textInputContextMenu.y = textInputMouseArea.mouseY
Expand All @@ -1454,10 +1462,14 @@ Rectangle {
id: textInputContextMenu
MenuItem {
text: qsTr("Cut")
enabled: textInput.selectedText !== ""
height: enabled ? implicitHeight : 0
onTriggered: textInput.cut()
}
MenuItem {
text: qsTr("Copy")
enabled: textInput.selectedText !== ""
height: enabled ? implicitHeight : 0
onTriggered: textInput.copy()
}
MenuItem {
Expand Down
Loading