Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix folder dialog on linux so that we can select the folder properly. #2541

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

manyoso
Copy link
Collaborator

@manyoso manyoso commented Jul 3, 2024

OMG, I can't believe I am just NOW figuring this out.

Apparently, on Linux you have to select the folder not enter it. NOTE: THIS MUST BE TESTED ON WINDOWS AND MAC TO MAKE SURE IT STILL WORKS!


🚀 This description was created by Ellipsis for commit 9ebae03

Summary:

Fixed folder selection issue on Linux by changing the property used to retrieve the selected folder in openFolderDialog function.

Key points:

  • Fixed folder selection issue on Linux by changing from folderDialog.currentFolder to folderDialog.selectedFolder.
  • Files affected: gpt4all-chat/qml/AddCollectionView.qml, gpt4all-chat/qml/MySettingsStack.qml.
  • Functions modified: openFolderDialog in both AddCollectionView.qml and MySettingsStack.qml.
  • Testing required: Verify functionality on Windows and Mac.

Generated with ❤️ by ellipsis.dev

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso manyoso requested a review from cebtenzzre July 3, 2024 13:05
Copy link
Member

@cebtenzzre cebtenzzre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on macOS and Windows as well.

@manyoso manyoso merged commit cd100c8 into main Jul 3, 2024
6 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants