Make the stop generation button visible during model response. #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Treat <treat.adam@gmail.com>
|
Hm, that doesn't seem like an obvious place for the button, compared to where it was in v2.8.0 - especially since sending otherwise works while the LLM is responding (though maybe that's itself an issue). Maybe it should at least be a different color, so it's more noticeable?
|
|
This was another inspiration from ChatGPT which has this now and also noticing that the 'send message' shouldn't be enabled when the model is in middle of response:
|
|
That's really nice touch, makes so much sense to add it here – I think it would look nicer if we could signify a bit more that it's a button by using a light background What do you think of it? 
|
Without this change, the message can still be sent using the Enter key, even though the "Stop" icon is visible. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
|
Done |
cebtenzzre
approved these changes
Jul 10, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that it is always clear when the response is still being generated and it also makes it easier to stop generation. Seems like a decent solution?
Summary:
Moved the stop generation button to a more prominent location and ensured its visibility during response generation in
gpt4all-chat/qml/ChatView.qml, with theme property updates ingpt4all-chat/qml/Theme.qml.Key points:
gpt4all-chat/qml/ChatView.qmlto move thestopButtonoutside the conversation tray and make it always visible during response generation.stopButtonvisibility conditions tocurrentChat.responseInProgress && !currentChat.isServer.gpt4all-chat/qml/Theme.qml:sendButtonBackgroundtoconversationInputButtonBackgroundsendButtonBackgroundHoveredtoconversationInputButtonBackgroundHovered.stopButtonis more accessible and easier to use during response generation.Generated with ❤️ by ellipsis.dev