Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable unsigned installers #2976

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Enable unsigned installers #2976

merged 2 commits into from
Oct 9, 2024

Conversation

johnwparent
Copy link
Collaborator

@johnwparent johnwparent commented Sep 20, 2024

Assigning a negative value to the GPT4ALL_SIGN_INSTALL CMake option will now allow for the production of unsigned installers.

This is also the default behavior as signing is not enabled unless explicitly requested.

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Steps to Reproduce

Notes

cc @cebtenzzre

a negative value for the GPT4ALL_SIGN_INSTALL CMake option will now allow for the production of unsigned installers

Signed-off-by: John Parent <john.parent@kitware.com>
Whether the app is a bundle or not should not depend on
GPT4ALL_SIGN_INSTALL.

Signed-off-by: Jared Van Bortel <jared@nomic.ai>
@manyoso manyoso merged commit 6bb42ed into main Oct 9, 2024
4 of 10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants