Establish basic compiler warnings, and fix a few style issues #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
This will make it easier to see compiler warnings in output, should they occur. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
This is an example of a commit that introduces a new warning flag to the build, and fixes any existing problems that the new warning detects. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
manyoso
reviewed
Oct 8, 2024
manyoso
approved these changes
Oct 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the doubled semicolon issue in #3034, and decided to split it out into this PR.
I figured -Wextra-semi was worth enabling if we are going to care about this kind of thing, even though it warns about a slightly different situation (one or more semicolons where there should not be any).
And if we're going to add -Wextra-semi to the build, we may as well also add -Wall.
And that if we're going to add -Wall, we should also add some other useful warning flags that don't cause any warnings to be printed for the current code.
And we may as well fix the singular warnings about each of -Wunused-lambda-capture, -Wunused-private-field, and -Wmissing-braces so we can enable those too.