Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added quote.py for quote and solved the #7 issue. #13

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

shyamcody
Copy link

used the wikiquotes library to pull quotes from the wikimedia's quote api. quote.py contains a function tell_quote.

Copy link
Member

@GauravSingh9356 GauravSingh9356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json parser is not working, well I have looked upon it and found that some quotes may not be retrieved correctly. What I have done is to add quotes of the day in en language and it's working fine

@GauravSingh9356 GauravSingh9356 added hacktoberfest hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 7, 2020
@shyamcody
Copy link
Author

shyamcody commented Oct 7, 2020

Thanks for the input @GauravSingh9356 .
There was a small issue in my code... that's why finally it was failing. I am pushing a new commit; check once more.
But the issue with quote_of_the_day is essentially that it will generate 1 quote par day. Other option is for us to detect wrongly retrieved quotes and correct it using text cleaning. I have a text cleaning function in work for the same issue. Let me know what types of quotes are not cleaned by it and I can extend that. Otherwise, if you are fine with the fact that jarvis will tell only one quote par day, then it's fine.

@GauravSingh9356 GauravSingh9356 merged commit 5f677d4 into noobDevelopers:master Oct 7, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
hacktoberfest hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants