Skip to content

Commit

Permalink
fix: updated package name to follow best practices
Browse files Browse the repository at this point in the history
  • Loading branch information
Noodl Windows Build User committed Jan 30, 2024
1 parent 78af7d6 commit 42e065b
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 12 deletions.
5 changes: 2 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
"graph": "npx nx graph",
"ci:prepare:editor": "ts-node ./scripts/ci-editor-prepare.ts",
"ci:build:viewer": "lerna exec --scope @noodl/noodl-viewer-react -- npm run build",
"ci:build:editor": "lerna exec --scope Noodl-Editor -- npm run ci:build",
"ci:build:editor": "lerna exec --scope noodl-editor -- npm run ci:build",
"build:editor": "ts-node ./scripts/build-editor.ts",
"build:editor:_viewer": "ts-node ./scripts/noodl-editor/build-viewer.ts",
"build:editor:_editor": "ts-node ./scripts/noodl-editor/build-editor.ts",
"build:editor:pack": "ts-node ./scripts/build-pack.ts",
"build:cloud-runtime": "lerna run build --scope @noodl/cloud-runtime --stream && lerna run build:pack --scope @noodl/cloud-runtime --stream",
"start:storybook": "lerna exec --scope @noodl/noodl-core-ui -- npm run start",
"start:viewer": "lerna run start --scope @noodl/noodl-viewer-react --stream",
"start:editor": "lerna run start --scope Noodl-Editor --stream",
"start:editor": "lerna run start --scope noodl-editor --stream",
"dev": "ts-node ./scripts/start.ts",
"start": "ts-node ./scripts/start.ts -- --build-viewer",
"test:editor": "ts-node ./scripts/test-editor.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/noodl-editor/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "Noodl-Editor",
"name": "noodl-editor",
"productName": "Noodl Editor",
"description": "Low-code for when experience matter",
"author": "Noodl <info@noodl.net>",
Expand Down
2 changes: 1 addition & 1 deletion packages/noodl-editor/src/editor/src/pages/AppRoute.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { AppRouter } from "Noodl-Editor/src/editor/src/pages/AppRouter";
import { AppRouter } from "noodl-editor/src/editor/src/pages/AppRouter";

export class AppRoute {
constructor(public readonly router: AppRouter) {}
Expand Down
6 changes: 3 additions & 3 deletions scripts/noodl-editor/build-editor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ import { getCurrentPlatform } from '../helper';
// NOTE: Getting error "Cannot set properties of null (setting 'dev')" here,
// It basically means that some package is not relative to this path.
console.log("--- Run 'npm install' ...");
execSync(`npm install --arch=${arch} --scope Noodl-Editor`, {
execSync(`npm install --arch=${arch} --scope noodl-editor`, {
stdio: 'inherit',
env: process.env
});
})
console.log("--- 'npm install' done!");

// NOTE: npm install --arch= does this too
Expand All @@ -89,7 +89,7 @@ import { getCurrentPlatform } from '../helper';
// Build: Replace "dugite"
// Build: Replace "desktop-trampoline"
console.log("--- Run 'npm run build' ...");
execSync('npx lerna exec --scope Noodl-Editor -- npm run build', {
execSync('npx lerna exec --scope noodl-editor -- npm run build', {
stdio: 'inherit',
env: {
...process.env,
Expand Down
2 changes: 1 addition & 1 deletion scripts/start.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const cloudRuntimeProcess = attachStdio(
}
);

const editorProcess = attachStdio(exec('npx lerna exec --scope Noodl-Editor -- npm run start', processOptions), {
const editorProcess = attachStdio(exec('npx lerna exec --scope noodl-editor -- npm run start', processOptions), {
prefix: 'Editor',
color: ConsoleColor.FgCyan
});
Expand Down
2 changes: 1 addition & 1 deletion scripts/test-editor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ console.log(
);
console.log("---");

execSync("npx lerna exec --scope Noodl-Editor -- npm run test", {
execSync("npx lerna exec --scope noodl-editor -- npm run test", {
cwd: CWD,
stdio: "inherit",
env: {
Expand Down

0 comments on commit 42e065b

Please # to comment.