Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Changes to sensor configs #545

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Changes to sensor configs #545

merged 1 commit into from
Jan 4, 2025

Conversation

olalid
Copy link
Collaborator

@olalid olalid commented Dec 28, 2024

Sensor energy_per_hour changed name changed to energy_last_hour and disabled by default to hopefully cause less confusion about what it means/does.
A few more diagnostic attributes added to charger online sensor.

@github-actions github-actions bot added the translation Translations label Dec 28, 2024
@olalid olalid mentioned this pull request Dec 28, 2024
Closed
@olalid olalid added the enhancement New feature or request label Jan 3, 2025
astrandb
astrandb approved these changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@astrandb astrandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
"energy_per_hour" could be removed from en.json but since it needs a manual intervention in Lokalize it can wait. I'll make a note of it for later...

@olalid olalid merged commit abbed13 into master Jan 4, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@astrandb astrandb astrandb approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request translation Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olalid @astrandb