Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CostData class for handling of cost updates added #561

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

olalid
Copy link
Collaborator

@olalid olalid commented Jan 14, 2025

Delays and collects updates in to call for all chargers on a site.

Copy link
Collaborator

@astrandb astrandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine.
I have added a few minor suggestions around typing that will make code easier to follow. There is room for improving typing much more but that should be a topic for separate PR:s

custom_components/easee/controller.py Outdated Show resolved Hide resolved
custom_components/easee/controller.py Outdated Show resolved Hide resolved
custom_components/easee/controller.py Outdated Show resolved Hide resolved
custom_components/easee/controller.py Outdated Show resolved Hide resolved
olalid and others added 4 commits January 15, 2025 11:17
Co-authored-by: Åke Strandberg <ake@strandberg.eu>
Co-authored-by: Åke Strandberg <ake@strandberg.eu>
Co-authored-by: Åke Strandberg <ake@strandberg.eu>
Co-authored-by: Åke Strandberg <ake@strandberg.eu>
@olalid
Copy link
Collaborator Author

olalid commented Jan 15, 2025

Yes, I think there is a slight chance of a race condition where a new poll could happen right after another, but I think we can work on that later, better to get this out there as soon as we can.

@olalid olalid merged commit a232f02 into master Jan 15, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants