Comment Color Brightness #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svengreb
approved these changes
May 11, 2019
The value is calculated using the Sass `lighten` (1) function to ensure full interoperability with other port projects that providing this theme feature. References: (1) sass-lang.com/documentation/functions/color#lighten GH-6
-> Please see nordtheme/nord#94 for all details about this design change decision. Increased the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%. GH-6
arcticicestudio
force-pushed
the
improvement/gh-6-comment-color-brightness
branch
from
a2152cf to
de2b874
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After