refactor: better way to ensure page has been loaded #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondaychen
force-pushed
the
wait_for_html_render
branch
from
c6da469 to
1bb7675
Compare
lynchee-owo
reviewed
Apr 9, 2024
| return activeTab?.status === "complete"; | ||
| }, | ||
| 200, // check every 200ms | ||
| 100, // wait for up to 20 seconds (100*200ms) |
There was a problem hiding this comment.
just a thought. 20s itself seems to be a long time, maybe better to couple with some UI indication of waiting such as showing "still waiting for the page to load" for every 5 second. This is not necessary though, because it's rare that some pages take ~20s to load.
There was a problem hiding this comment.
Good point! added issue #109
lynchee-owo
approved these changes
Apr 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #96