#dup with unslugged model causes undefined method error #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In lib/friendly_id/base.rb:252:
```
def dup
super.tap { |duplicate| duplicate.slug = nil }
end
```
However, suppose we have a User with just `friendly_id :login` - no extra slug. #slug= is not defined, and therefore some_user.dup fails.
My patch just makes the dup check if slug= is defined before using it.
|
Changes Unknown when pulling 996a073 on saizai:patch-1 into * on norman:master*. |
1 similar comment
|
Changes Unknown when pulling 996a073 on saizai:patch-1 into * on norman:master*. |
|
@norman ? |
norman
added a commit
that referenced
this pull request
Feb 6, 2014
#dup with unslugged model causes undefined method error
|
Looks good - thanks! |
|
W00t. :-) |
|
Could you bump the version # etc so it gets published? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lib/friendly_id/base.rb:252, as introduced in SHA: aa3b4a6:
However, suppose we have a User with just
friendly_id :login- no extra slug. #slug= is not defined, and therefore some_user.dup fails.My patch just makes the dup check if slug= is defined before using it.