Make Candidates#each iterable without block.

[ihnatz]

Hi

The mean aim of this commit is to provide access to generated slug candidates without direct AR manipulations

FriendlyId::Candidates.new(model, model.slug_candidates).each 
# => ["ergonomic-zero-es-africa", "ergonomic-zero-es-africa-100"]
# instead of 
# LocalJumpError: no block given (yield)

So, it seems reasonable for me to use this syntax instead of calling #save. It can be written to return Enumerator instead of array, but it will be not so readable and will complicate method.

[parndt]

Oh, I like this! We'll need tests (please ❤️) to ensure that the functionality works like you say it does now and in the future, though. :)

[ihnatz]

Ok, no problem

[coveralls]

Coverage increased (+0.0%) to 99.07% when pulling 307cf17 on ignat-zakrevsky:minor-candidates-each-update into b5290a9 on norman:master.

[coveralls]

Coverage increased (+0.0%) to 99.07% when pulling 307cf17 on ignat-zakrevsky:minor-candidates-each-update into b5290a9 on norman:master.

[coveralls]

Coverage increased (+0.0%) to 99.07% when pulling 307cf17 on ignat-zakrevsky:minor-candidates-each-update into b5290a9 on norman:master.

[coveralls]

Coverage increased (+0.0%) to 99.07% when pulling 307cf17 on ignat-zakrevsky:minor-candidates-each-update into b5290a9 on norman:master.

[ihnatz]

@parndt, updated

[parndt]

@norman over to you.

FYI, CI is (and was before this patch) failing due to ActiveRecord 4.2 + postgresql + jruby.. I had a very similar / the same thing happen in awesome_nested_set (commit), though I'm not exactly sure why it fails here.

Here's the awesome_nested_set job

[norman]

Merged, thanks!

[norman]

This is now out in 5.2.0.beta.1. No timetable for stable release yet, but probably within a couple weeks.