Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Configurable telemetry event filtering #149

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Configurable telemetry event filtering #149

merged 3 commits into from
Nov 26, 2024

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Nov 25, 2024 •
edited
Loading

Adds support for a new Telemetry configuration key that allows admins to specify the event types that should be logged.

This PR deprecated the EnableForkAndExitLogging key.

Fixes #126

@mlw mlw added configurator Issues or PRs related to the configurator / Santa configuration comp/santad Issues or PRs related to the daemon telemetry Issues / PRs that change the telemetry output 🪵 logging labels Nov 25, 2024
@mlw mlw requested a review from a team as a code owner November 25, 2024 21:23
pmarkowsky
pmarkowsky requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor things.

@pmarkowsky pmarkowsky mentioned this pull request Nov 26, 2024
Open
@mlw mlw force-pushed the telemetry-event-filtering-basic branch from 5b55659 to d78dfcc Compare November 26, 2024 15:21
@mlw mlw requested a review from pmarkowsky November 26, 2024 15:23
pmarkowsky
pmarkowsky approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw added this to the 2024.11 milestone Nov 26, 2024
@mlw mlw merged commit 1a0107c into northpolesec:main Nov 26, 2024
10 checks passed
@mlw mlw mentioned this pull request Nov 26, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
comp/santad Issues or PRs related to the daemon configurator Issues or PRs related to the configurator / Santa configuration 🪵 logging telemetry Issues / PRs that change the telemetry output
Projects
None yet
Milestone
2024.11
Development

Successfully merging this pull request may close these issues.

Minimal Telemetry Event Filtering
2 participants
@mlw @pmarkowsky