Standalone: Switch to a hold-and-ask model (part 1) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlw
reviewed
Dec 16, 2024
mlw
reviewed
Dec 16, 2024
github-actions
bot
added
comp/santad
github-actions
bot
added
gui
size/xl
With these changes, instead of denying execution and then making a rule after authorization, now when in Standalone mode the execution will be allowed but the binary immediately paused with SIGSTOP. If the user authorizes the execution, the binary will be resumed with SIGCONT (as well as a rule being created). While a process is stopped pending user authorization, any other process attempting to send SIGCONT will be blocked. If the GUI is unavailable for any reason, the process will immediately be killed. This PR does not change logging, so currently all held executions will be logged as if they were an allowed execution even though they may be killed later before the binary ever had the change to execute anything. This will be fixed in a follow-up PR
russellhancox
force-pushed
the
rah/standalone-hold-and-ask
branch
from
aee0357 to
92d85bd
Compare
github-actions
bot
added
size/m
mlw
requested changes
Dec 18, 2024
mlw
reviewed
Dec 19, 2024
mlw
reviewed
Dec 19, 2024
mlw
previously approved these changes
Dec 19, 2024
mlw
approved these changes
Dec 19, 2024
russellhancox
added
comp/gui
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, instead of denying execution and then making a rule after authorization, now when in Standalone mode the execution will be allowed but the binary immediately paused with
pid_suspend(). If the user authorizes the execution, the binary will be resumed withpid_resume()(as well as a rule being created). While a process is stopped pending user authorization, any other process attempting to sendpid_resume()will be blocked. If the GUI is unavailable for any reason, the process will immediately be killed.This PR does not change logging, so currently all held executions will be logged as if they were an allowed execution even though they may be killed later before the binary ever had the change to execute anything. This will be fixed in a follow-up PR.