Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add PID to the Title #77

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Add PID to the Title #77

merged 5 commits into from
Nov 9, 2023

Conversation

x3rt
Copy link
Member

@x3rt x3rt commented Oct 31, 2023

Adds the PID of the SCPSL process to the title.

@iamalexrouse
Copy link
Contributor

While I am not a maintainer, I see this could be helpful but as LocalAdmin is designed to hook directly into the server, I'm not sure what @zabszk will say but he's usually full of all sorts of wisdom.

@zabszk
Copy link
Member

zabszk commented Oct 31, 2023

Hi,

LocalAdmin title is changed in more places in the code. You need to change all of them. Otherwise the PID will be removed from the title when Idle Mode is enabled or disabled.

@x3rt
Copy link
Member Author

x3rt commented Nov 1, 2023

LocalAdmin title is changed in more places in the code. [...] The PID will be removed from the title when Idle Mode is enabled or disabled.

Completely missed that in testing as I have Idle mode disabled.

All works now. Let me know if you don't want me to use expression bodies or any other feedback

@zabszk zabszk self-assigned this Nov 1, 2023
@zabszk
Copy link
Member

zabszk commented Nov 1, 2023

The PR looks good now. I will merge it once #76 is merged and conflicts are resolved.

@zabszk
Copy link
Member

zabszk commented Nov 9, 2023

I'm merging this, because I'm still waiting for @MichalPetryka 's opinion about the LF/CRLF in #76.

@zabszk zabszk merged commit fea3246 into northwood-studios:master Nov 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants