ENH: Allow not printing coverage report #830
Conversation
| @@ -29,6 +29,7 @@ class Coverage(Plugin): | |||
| coverInstance = None | |||
| coverErase = False | |||
| coverMinPercentage = None | |||
| coverNoPrint = False | |||
There was a problem hiding this comment.
I'd flip the sense of this and set coverPrint = True. Then...
|
Agreed, double-negatives are not good. Comments addressed. |
|
Latest commit adds a simple test (just making sure the switch can be used). |
|
What is the status of this PR? I would like this option as well. |
|
Ready to go from my end as of ~6 months ago. |
|
Can this be merge ? Would be a good addition |
|
It can no longer be automatically merged (merge conflict). I'm happy to rebase, though, if the maintainers want this addition. |
|
@jszakmeister any comment on this one? I'm happy to rebase if necessary. Would be nice to have this option eventually. |
|
Rebase complete and Travis is happy. |
|
A couple of comments. I've seen others do this, but I'm not real fond of the "FIX", "STY", and "ENH" prefixes on commit messages. Also, there were a number of unrelated stylistic fixes in there too. I realize your editor probably helped you "fix" them, but it detracts from the actual changes that you make. I mention it because a number of projects would outright reject patches that did that, and I think it's best to error on the side of caution and refrain from it when contributing to other projects. That said, thank you. I'll merge this now. FWIW, I'm stepping down as maintainer, so Nose will be unmaintained after I cut the next patch release. |
ENH: Allow not printing coverage report
|
Thanks for the comments, (re-)review, merge, and maintenance effort (even though it's coming to an end soon). FWIW I do the prefixes because to my eye they have become a de facto standard in the scientific Python ecosystem (e.g., numpy, scipy, scikit-learn), but perhaps they're less common elsewhere in Python. |
Thank you.
As someone who has contributed to a number of open source projects for the past 15+ years, it's a good idea to see what the project does and follow their standards, instead of having them accept your own. It's makes the processes smoother, and it's one less thing that a maintainer has to comment on and tell you to fix. :-) Thanks again. :-) |
Code changes proposed to address #829.
Closes #829.