-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds an option to specify the location of the coverage config file. #896
Adds an option to specify the location of the coverage config file. #896
Conversation
What's the motivation here? Why do you not have the coverage config file in the same directory that you're running nose? Also, not much gets merged these days without tests. |
Thanks for taking the time to look at this pull request, John.
I dislike the inconsistency of how different Python projects handle configuration files. Some projects by default use a visible config file, some use a hidden dotfile, others use setup.cfg, etc. In this case, coverage allows me to move the config file but nose doesn't currently pass that configuration forward.
I can sympathize. I looked into adding testing for this particular option but it didn't seem like there was significant testing for coverage configuration options to begin with. You can expect the next commit to have additional testing. |
I see. You want to do it a particular way, and we stand in the way.
That happens, yes. Nose has been around a while, and even though there a lots of tests, it still lacks in some areas. The project's standards have evolved over time, so some portions are lacking. Thank you for improving the situation. |
Thank you for understanding. |
8f8c583
to
241af6b
Compare
Conflicts: nose/plugins/cover.py
241af6b
to
89687d0
Compare
Ping. I just wanted to get an update on the status of this and if there is anything left for me to do. |
Can you fix up the history to squash the relevant fix commits into the original ones? Sorry, but I'm a bit picky about that stuff, especially since I spend so much time tracking down bugs. |
Adds an option to specify the location of the coverage config file.
Merged an amended version of this in 0f592c4. |
Adds an option to specify the location of the coverage config file.