BUG: Tee doesn't have encoding or errors attrs. #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Python3, distutils.log uses the encoding and errors attribute of sys.stdout and stderr. Tests error out when nose is run with xunit and it replaces the stdout/stderr with a Tee.
jszakmeister
added a commit
to jszakmeister/nose
that referenced
this pull request
Nov 28, 2015
Tee doesn't have encoding and errors attributes.
|
I amended this PR to avoid failures when distutils.log is not available, and merged it. Thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python3,
distutils.loguses the encoding and errors attribute ofsys.stdout and stderr. Tests error out when nose is run with xunit and
it replaces the stdout/stderr with a Tee.
The tests in this PR are rudimentary and only fix the problem I was facing.