Reorganize Nostr event code to be grouped by event kind #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have one massive
EventCreating.swift
file that contains all the Nostr event creation functions. That approach is not scalable because the file will grow without bound as we support more event kinds. Moreover, it becomes increasingly difficult to maintain that code.Similarly, we have massive
EventCreatingTests.swift
andEventDecodingTests.swift
test files which also grow without bound and are difficult to maintain.I've reorganized the code so that the
EventCreating
protocol function(s) that create a specific Nostr event kind will be located in the same file as where the Nostr event kind class is defined. Moreover, the tests for each Nostr event kind were reorganized such that the creation and decoding is located in the same test file, specific to that Nostr event kind.There is no change in any functionality or public function contracts. The only changes were: