Add missing NostrEvent subclass mappings from the EventKind enum #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyiu
commented
Apr 19, 2024
| case .muteList: return 10000 | ||
| case .bookmarksList: return 10003 | ||
| case .longformContent: return 30023 | ||
| case .setMetadata: return 0 |
There was a problem hiding this comment.
No functional changes on rawValue, only indentation for readability.
| } | ||
|
|
||
| /// The ``NostrEvent`` subclass associated with the kind. | ||
| public var classForKind: NostrEvent.Type { |
There was a problem hiding this comment.
I moved classForKind from EventKindMapper in RelayResponse to here for colocation purposes so that it's easier to maintain the EventKind enum as we add more.
tyiu
force-pushed
the
tyiu/fix-class-for-kind
branch
from
31500a2 to
4223699
Compare
tyiu
force-pushed
the
tyiu/fix-class-for-kind
branch
from
4223699 to
9c782fa
Compare
bryanmontz
approved these changes
Apr 20, 2024
RandyMcMillan
pushed a commit
to RandyMcMillan/nostr-sdk-ios
that referenced
this pull request
Sep 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.