Add support for NIP-59 gift wraps #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmontz
requested changes
May 28, 2024
Co-authored-by: Bryan Montz <bryanmontz@me.com>
bryanmontz
approved these changes
May 28, 2024
RandyMcMillan
pushed a commit
to RandyMcMillan/nostr-sdk-ios
that referenced
this pull request
Sep 1, 2024
* Add support for NIP-59 gift wraps * Apply suggestions from code review Co-authored-by: Bryan Montz <bryanmontz@me.com> * Fix callsites to GiftWrapEvent and SealEvent functions that were renamed --------- Co-authored-by: Bryan Montz <bryanmontz@me.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIP-59 - Gift Wrap
This PR introduces two new kinds:
This PR also contains a breaking change where
signatureonNostrEventis now optional to accommodate unsigned events (aka rumors).After this change gets in, we will be unblocked with implementing NIP -17 - Private Direct Messages.