Expand testclient to test delegations and root rotations #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Input comes before the username/password, and if there is a username | ||
| # and password, we need a newline after the input. Otherwise, just use | ||
| # EOF (for instsance if we're piping text to verify) |
cyli
force-pushed
the
expand_testclient
branch
2 times, most recently
from
7e0473b to
bdace49
Compare
cyli
changed the title
|
Needs a rebase but seems like we should merge this. |
|
|
||
| def add_delegation_test(self, tempfile, tempdir): | ||
| """ | ||
| Add a delegation to the repo - assumes hte repo has already been initialized |
|
this is awesome, would love to have this merged and running in CI! LGTM pending nits and rebase. |
cyli
force-pushed
the
expand_testclient
branch
3 times, most recently
from
3a49c1c to
5e65084
Compare
|
#882 fixes this issue, so once that is merged this can be merged. |
cyli
force-pushed
the
expand_testclient
branch
from
e351e4a to
3e8e37e
Compare
…king and root rotation checking, the script is getting more complex with text mangling. Signed-off-by: Ying Li <ying.li@docker.com>
…ent.py file Signed-off-by: Ying Li <ying.li@docker.com>
Signed-off-by: Ying Li <ying.li@docker.com>
cyli
force-pushed
the
expand_testclient
branch
from
3e8e37e to
9135e90
Compare
Signed-off-by: Ying Li <ying.li@docker.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more extensive delegation tests and root rotation tests to our test client.
Also, this can be used against Docker Hub.